test: re-work test strategy for integration tests #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3443 +/- ##
==========================================
+ Coverage 85.31% 85.36% +0.04%
==========================================
Files 167 167
Lines 7415 7412 -3
==========================================
+ Hits 6326 6327 +1
+ Misses 800 798 -2
+ Partials 289 287 -2 see 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
odubajDT
changed the title
odubajDT
changed the title
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
chore/rework-integration-tests
branch
from
1d2c0fd to
201134e
Compare
Signed-off-by: odubajDT <[email protected]>
bacherfl
reviewed
Apr 22, 2024
bacherfl
reviewed
Apr 22, 2024
bacherfl
reviewed
Apr 22, 2024
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
|
bacherfl
approved these changes
Apr 22, 2024
thisthat
reviewed
Apr 22, 2024
thisthat
approved these changes
Apr 22, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
security scans:
https://github.com/keptn/lifecycle-toolkit/actions/runs/8752659807
Changes
Reworked integration tests cluster setups to batches and run appropriate tests on each setup. Each cluster setup has Keptn installation with a custom values.yaml file, which enables/disables Keptn components or features.
A single integration test workflow was divided into multiple, so that each workflow sets up 1-3 different clusters with similar settings and runs the tests on them
The installation action for installing Keptn on cluster was simplified to accept fewer parameters (especially path to values.yaml file user for installation of Keptn)
Not all tests are ran with all possible combinations of cluster setup -> there is no need for such testing, we are aiming for testing certain functionality with certain cluster setup. Every test is ran at least once, max 3x on different cluster setups (where it makes sense to run).
Runtime for integration tests was reduced from ~20min to ~12min.