fix: introduce missing Role into keptn-cert-manager helm charts #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3435 +/- ##
=======================================
Coverage 85.31% 85.31%
=======================================
Files 167 167
Lines 7415 7415
=======================================
Hits 6326 6326
Misses 800 800
Partials 289 289
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
bacherfl
reviewed
Apr 18, 2024
bacherfl
previously approved these changes
Apr 18, 2024
mowies
reviewed
Apr 18, 2024
Signed-off-by: odubajDT <[email protected]>
|
RealAnna
approved these changes
Apr 19, 2024
bacherfl
approved these changes
Apr 19, 2024
This was referenced Apr 19, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
…n#3435) Signed-off-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3434
Changes
keptn-cert-managerunit testskeptn-cert-managerleader election in helm chartsschedulerleader election in helm chartsTesting
The fix was manually tested and it's working. Even the scenario with installed
lifecycle-operatorand disabledmetrics-operatorwas tested and it's working. Automated tests will be provided in a follow-up.