Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update module google.golang.org/grpc to v1.63.0 - abandoned #3392

Closed
wants to merge 5 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
google.golang.org/grpc v1.62.1 -> v1.63.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

grpc/grpc-go (google.golang.org/grpc)

v1.63.0: Release 1.63.0

Compare Source

Behavior Changes

  • grpc: Return canonical target string from resolver.Address.String() (experimental) (#​6923)
  • client & server: when using write buffer pooling, use input value for buffer size instead of size*2 (#​6983)

New Features

  • grpc: add ClientConn.CanonicalTarget() to return the canonical target string. (#​7006)
  • xds: implement LRS named metrics support (gRFC A64) (#​7027)
  • grpc: introduce grpc.NewClient to allow users to create new clients in idle mode and with "dns" as the default resolver (#​7010)

API Changes

  • grpc: stabilize experimental method ClientConn.Target() (#​7006)

Bug Fixes

  • xds: fix an issue that would cause the client to send an empty list of resources for LDS/CDS upon reconnecting with the management server (#​7026)
  • server: Fix some errors returned by a server when using a grpc.Server as an http.Handler with the Go stdlib HTTP server (#​6989)
  • resolver/dns: add SetResolvingTimeout to allow configuring the DNS resolver's global timeout (#​6917)
  • Set the security level of Windows named pipes to NoSecurity (#​6956)

v1.62.2: Release 1.62.2

Compare Source

Dependencies


Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot requested a review from a team as a code owner April 6, 2024 22:25
Copy link
Contributor Author

renovate bot commented Apr 6, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: scheduler/go.sum
Command failed: go get -d -t ./...
go: k8s.io/[email protected]: reading k8s.io/kube-scheduler/go.mod at revision v0.0.0: unknown revision v0.0.0

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.98%. Comparing base (3b093bc) to head (f020e8b).
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3392       +/-   ##
===========================================
- Coverage   85.33%   58.98%   -26.35%     
===========================================
  Files         167       35      -132     
  Lines        7412     1997     -5415     
===========================================
- Hits         6325     1178     -5147     
+ Misses        799      671      -128     
+ Partials      288      148      -140     

see 144 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 69.23% <ø> (ø)
component-tests 58.53% <ø> (+0.48%) ⬆️
lifecycle-operator ?
metrics-operator ?
scheduler 34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

bacherfl
bacherfl previously approved these changes Apr 8, 2024
Signed-off-by: Florian Bacher <[email protected]>
Copy link
Contributor Author

renovate bot commented Apr 8, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

bacherfl added 2 commits April 8, 2024 08:51
Signed-off-by: Florian Bacher <[email protected]>
want: ctrl.Result{Requeue: true, RequeueAfter: 10 * time.Second},
wantErr: true,
want: ctrl.Result{},
wantErr: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is due to the use of the grpc.NewClient() function which replaces the deprecated grpc.DialContext() function. This switch changes the behavior by not attempting to connect to the target URL anymore, and therefore not returning an error when an unreachable URL is set.

Signed-off-by: Florian Bacher <[email protected]>
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bacherfl
Copy link
Member

bacherfl commented Apr 8, 2024

Note that merging this introduces a slight behavioural change due to the changes in the grpc library, which results in not receiving an error when initialising the grpc client for the OpenTelemetry exporter if the provided collector URL is not reachable.

@odubajDT odubajDT added the on hold Do not merge yet label Apr 10, 2024
@renovate renovate bot changed the title deps: update module google.golang.org/grpc to v1.63.0 deps: update module google.golang.org/grpc to v1.63.0 - abandoned Apr 15, 2024
Copy link
Contributor Author

renovate bot commented Apr 15, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@odubajDT odubajDT closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants