poc: integrate KeptnMetrics into Flagger analysis #3371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
added
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
==========================================
- Coverage 88.04% 85.31% -2.74%
==========================================
Files 176 167 -9
Lines 9604 7415 -2189
==========================================
- Hits 8456 6326 -2130
+ Misses 854 800 -54
+ Partials 294 289 -5 see 48 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <[email protected]>
StackScribe
reviewed
Apr 15, 2024
| In this example, we are making use of the Prometheus endpoint provided | ||
| by Keptn (i.e. the metrics-operator), which serves the values of all `KeptnMetrics`. | ||
|
|
||
| This way, we are able to use a Flagger `MetricTemplate` of type `prometheus`, |
There was a problem hiding this comment.
Suggested change
| This way, we are able to use a Flagger `MetricTemplate` of type `prometheus`, | |
| This enables us to use a Flagger `MetricTemplate` of type `prometheus`, |
StackScribe
reviewed
Apr 15, 2024
| by Keptn (i.e. the metrics-operator), which serves the values of all `KeptnMetrics`. | ||
|
|
||
| This way, we are able to use a Flagger `MetricTemplate` of type `prometheus`, | ||
| which retrieves the value from a Prometheus instance that has access to the `KeptnMetrics`. |
There was a problem hiding this comment.
Suggested change
| which retrieves the value from a Prometheus instance that has access to the `KeptnMetrics`. | |
| which retrieves the value from a Prometheus instance that has access to the `KeptnMetrics` resource. |
StackScribe
reviewed
Apr 15, 2024
| The example is based on the [Istio Canary Deployments tutorial](https://docs.flagger.app/tutorials/istio-progressive-delivery) | ||
| provided in the Flagger docs. | ||
|
|
||
| The difference to the tutorial is that instead of using the `request-duration` duration |
There was a problem hiding this comment.
Suggested change
| The difference to the tutorial is that instead of using the `request-duration` duration | |
| The difference from the tutorial is that, instead of using the `request-duration` duration |
Signed-off-by: Florian Bacher <[email protected]>
|
|
This PR has been automatically marked as stale because it has not had recent activity. It will be |
|
since this is an old PoC i believe we can close it, please re-open if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for a PoC - DO NOT MERGE
Part of #3050