-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lifecycle-operator): clean up unused API logic #3351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
ops
lifecycle-operator
labels
Mar 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
==========================================
- Coverage 88.04% 85.29% -2.76%
==========================================
Files 176 167 -9
Lines 9604 7412 -2192
==========================================
- Hits 8456 6322 -2134
+ Misses 854 801 -53
+ Partials 294 289 -5
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
odubajDT
force-pushed
the
feat/3235/cleanup-api
branch
from
March 26, 2024 14:04
be8909b
to
49d218f
Compare
bacherfl
approved these changes
Mar 26, 2024
thisthat
reviewed
Mar 26, 2024
thisthat
reviewed
Mar 27, 2024
lifecycle-operator/apis/lifecycle/v1beta1/keptnappversion_conversion_test.go
Show resolved
Hide resolved
lifecycle-operator/apis/lifecycle/v1beta1/keptnappversion_conversion_test.go
Show resolved
Hide resolved
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
feat/3235/cleanup-api
branch
from
March 27, 2024 09:05
49d218f
to
17d821b
Compare
Quality Gate passedIssues Measures |
thisthat
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
Vickysomtee
pushed a commit
to Vickysomtee/keptn-lifecycle-toolkit
that referenced
this pull request
Apr 23, 2024
Signed-off-by: odubajDT <[email protected]> Signed-off-by: vickysomtee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #3350