Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: review keptntaskdefinition examples #3085

Merged
merged 60 commits into from
Feb 26, 2024
Merged

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Feb 20, 2024

Summary

This pr cleans up our KeptnTaskDefinition examples

Fixes #3083

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

@github-actions github-actions bot added documentation Improvements or additions to documentation lifecycle-operator ops labels Feb 20, 2024
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
@RealAnna RealAnna force-pushed the docs/update-examples-for-tasks branch from 9580a24 to 778dbbb Compare February 23, 2024 09:34
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
@RealAnna RealAnna marked this pull request as ready for review February 23, 2024 12:48
@RealAnna RealAnna requested review from a team as code owners February 23, 2024 12:48
@RealAnna RealAnna force-pushed the docs/update-examples-for-tasks branch from 1d52c02 to d731db4 Compare February 23, 2024 12:50
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
@RealAnna RealAnna force-pushed the docs/update-examples-for-tasks branch from ecd967e to ccf6f4a Compare February 26, 2024 09:24
Signed-off-by: RealAnna <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RealAnna RealAnna merged commit d0a0c43 into main Feb 26, 2024
31 of 32 checks passed
@RealAnna RealAnna deleted the docs/update-examples-for-tasks branch February 26, 2024 10:10
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaskDefinition CRD Reference needs more examples
3 participants