fix(metrics-operator): provide more information for dynatrace api error

[Vickysomtee]

Description

This PR adds more information to the dynatrace api error response

Fixes #2790

How to test

Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.

• Manual Test A
• Unit Test B
• Integration Test C

Checklist

• My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
  into multiple PRs)
• I used descriptive commit messages to help reviewers understand my thought process
• I signed off all my commits according to the Developer Certificate of Origin (DCO)
  see Contribution Guide
• My PR title is formatted according to the semantic PR conventions described in
  the Contribution Guide
• My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
• I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
• I have performed a self-review of my code
• I have made corresponding changes to the documentation (if needed)
• My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
• New and existing unit and integration tests pass locally with my changes

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.32%. Comparing base (e048679) to head (131675f).

❗ Current head 131675f differs from pull request most recent head b34e7ab. Consider uploading reports for the commit b34e7ab to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2885      +/-   ##
==========================================
- Coverage   85.36%   85.32%   -0.05%     
==========================================
  Files         167      167              
  Lines        7412     7412              
==========================================
- Hits         6327     6324       -3     
- Misses        798      800       +2     
- Partials      287      288       +1     

Files	Coverage Δ
...ollers/common/providers/dynatrace/client/client.go	72.72% <60.00%> (ø)

... and 1 file with indirect coverage changes

Flag	Coverage Δ
certificate-operator	69.23% <ø> (ø)
component-tests	58.53% <ø> (-0.25%)	⬇️
lifecycle-operator	83.46% <ø> (ø)
metrics-operator	88.32% <60.00%> (ø)
scheduler	34.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[RealAnna]

Hey @Vickysomtee the ticket requests a Chainsaw test using mockserver, you can copy the implementation of this test but change it for a failing http response to show what would be printed by the operator.

The idea is that the mockserver configuration can return a bad http code, and the result of the operator for example a keptn metric should be the error message you added.

[Vickysomtee]

Hey @Vickysomtee the ticket requests a Kuttl test using mockserver, you can copy the implementation of this test but change it for a failing http response to show what would be printed by the operator.

The idea is that the mockserver configuration can return a bad http code, and the result of the operator for example a keptn metric should be the error message you added.

@RealAnna can you check the link in your comment? It links to a folder. Did you intend to link to a folder or a file

Also, just to note, I didn't introduce new error message. I only added statusCode

[RealAnna]

Hey @Vickysomtee indeed, I had in mind you changed also the printed message but apparently not... Anyhow line 106, 111 and 127 could use coverage by unit test. For the chainsaw test this is indeed a folder with multiple files, some file declare what the test wll install on the test environment and the other assert the expected result. YOu can have a look at how it works here

[bacherfl]

Hi @Vickysomtee, any news on this one? feel free to reach out if you have any questions

[Vickysomtee]

Hi @Vickysomtee, any news on this one? feel free to reach out if you have any questions

@bacherfl I had a very tight schedule this past weeks. I am settled now, and I will round up this issue ASAP.

[Vickysomtee]

Yes the mock should match what I pasted here 👍

@RealAnna Done!

[Vickysomtee]

Hello @RealAnna can you help review again?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[odubajDT]

you are getting an empty status in the test result. I would say that's not expected. It should either return the value or error. Can you please adapt it accordingly?

[odubajDT]

closing due to inactivity