chore(lifecycle-operator): remove pre post deploy task evaluation v1beta1

.github/actions/spelling/expect.txt

@@ -91,6 +91,7 @@ configmapref
 configmapreference
 containedctx
 containerspec
+contextcommon
 contextdata
 controllercommon
 controllererrors

.github/scripts/.helm-tests/default/result.yaml

@@ -10777,6 +10777,14 @@ rules:
   - secrets
   verbs:
   - get
+- apiGroups:
+  - lifecycle.keptn.sh
+  resources:
+  - keptnappcontexts
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - lifecycle.keptn.sh
   resources:

.github/scripts/.helm-tests/lifecycle-only/result.yaml

@@ -8788,6 +8788,14 @@ rules:
   - secrets
   verbs:
   - get
+- apiGroups:
+  - lifecycle.keptn.sh
+  resources:
+  - keptnappcontexts
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - lifecycle.keptn.sh
   resources:

.github/scripts/.helm-tests/lifecycle-with-certs/result.yaml

@@ -8883,6 +8883,14 @@ rules:
   - secrets
   verbs:
   - get
+- apiGroups:
+  - lifecycle.keptn.sh
+  resources:
+  - keptnappcontexts
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - lifecycle.keptn.sh
   resources:

lifecycle-operator/apis/lifecycle/v1alpha1/keptnapp_conversion.go

@@ -27,10 +27,6 @@ func (src *KeptnApp) ConvertTo(dstRaw conversion.Hub) error {
 			Version: srcWl.Version,
 		})
 	}
-	dst.Spec.PreDeploymentTasks = src.Spec.PreDeploymentTasks
-	dst.Spec.PostDeploymentTasks = src.Spec.PostDeploymentTasks
-	dst.Spec.PreDeploymentEvaluations = src.Spec.PreDeploymentEvaluations
-	dst.Spec.PostDeploymentEvaluations = src.Spec.PostDeploymentEvaluations
 
 	dst.Status.CurrentVersion = src.Status.CurrentVersion
 
@@ -59,10 +55,6 @@ func (dst *KeptnApp) ConvertFrom(srcRaw conversion.Hub) error {
 			Version: srcWl.Version,
 		})
 	}
-	dst.Spec.PreDeploymentTasks = src.Spec.PreDeploymentTasks
-	dst.Spec.PostDeploymentTasks = src.Spec.PostDeploymentTasks
-	dst.Spec.PreDeploymentEvaluations = src.Spec.PreDeploymentEvaluations
-	dst.Spec.PostDeploymentEvaluations = src.Spec.PostDeploymentEvaluations
 
 	dst.Status.CurrentVersion = src.Status.CurrentVersion
 

lifecycle-operator/apis/lifecycle/v1alpha1/keptnapp_conversion_test.go

@@ -47,18 +47,6 @@ func TestKeptnApp_ConvertFrom(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: v1beta1.KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -88,18 +76,6 @@ func TestKeptnApp_ConvertFrom(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -161,18 +137,6 @@ func TestKeptnApp_ConvertTo(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -203,18 +167,6 @@ func TestKeptnApp_ConvertTo(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: v1beta1.KeptnAppStatus{
 					CurrentVersion: "1.2.3",

lifecycle-operator/apis/lifecycle/v1alpha1/keptnappversion_conversion_test.go

@@ -51,6 +51,8 @@ func TestKeptnAppVersion_ConvertFrom(t *testing.T) {
 								Version: "4.5.6",
 							},
 						},
+					},
+					DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
 						PreDeploymentTasks: []string{
 							"some-pre-deployment-task1",
 						},
@@ -471,6 +473,8 @@ func TestKeptnAppVersion_ConvertTo(t *testing.T) {
 								Version: "4.5.6",
 							},
 						},
+					},
+					DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
 						PreDeploymentTasks: []string{
 							"some-pre-deployment-task1",
 						},

lifecycle-operator/apis/lifecycle/v1alpha2/keptnapp_conversion.go

@@ -27,10 +27,6 @@ func (src *KeptnApp) ConvertTo(dstRaw conversion.Hub) error {
 			Version: srcWl.Version,
 		})
 	}
-	dst.Spec.PreDeploymentTasks = src.Spec.PreDeploymentTasks
-	dst.Spec.PostDeploymentTasks = src.Spec.PostDeploymentTasks
-	dst.Spec.PreDeploymentEvaluations = src.Spec.PreDeploymentEvaluations
-	dst.Spec.PostDeploymentEvaluations = src.Spec.PostDeploymentEvaluations
 
 	dst.Status.CurrentVersion = src.Status.CurrentVersion
 
@@ -58,10 +54,6 @@ func (dst *KeptnApp) ConvertFrom(srcRaw conversion.Hub) error {
 			Version: srcWl.Version,
 		})
 	}
-	dst.Spec.PreDeploymentTasks = src.Spec.PreDeploymentTasks
-	dst.Spec.PostDeploymentTasks = src.Spec.PostDeploymentTasks
-	dst.Spec.PreDeploymentEvaluations = src.Spec.PreDeploymentEvaluations
-	dst.Spec.PostDeploymentEvaluations = src.Spec.PostDeploymentEvaluations
 
 	dst.Status.CurrentVersion = src.Status.CurrentVersion
 

lifecycle-operator/apis/lifecycle/v1alpha2/keptnapp_conversion_test.go

@@ -47,18 +47,6 @@ func TestKeptnApp_ConvertFrom(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: v1beta1.KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -89,18 +77,6 @@ func TestKeptnApp_ConvertFrom(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -163,18 +139,6 @@ func TestKeptnApp_ConvertTo(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -205,18 +169,6 @@ func TestKeptnApp_ConvertTo(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: v1beta1.KeptnAppStatus{
 					CurrentVersion: "1.2.3",

lifecycle-operator/apis/lifecycle/v1alpha2/keptnappversion_conversion_test.go

@@ -51,6 +51,8 @@ func TestKeptnAppVersion_ConvertFrom(t *testing.T) {
 								Version: "4.5.6",
 							},
 						},
+					},
+					DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
 						PreDeploymentTasks: []string{
 							"some-pre-deployment-task1",
 						},
@@ -471,6 +473,8 @@ func TestKeptnAppVersion_ConvertTo(t *testing.T) {
 								Version: "4.5.6",
 							},
 						},
+					},
+					DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
 						PreDeploymentTasks: []string{
 							"some-pre-deployment-task1",
 						},

lifecycle-operator/apis/lifecycle/v1alpha3/keptnapp_conversion.go

@@ -27,10 +27,6 @@ func (src *KeptnApp) ConvertTo(dstRaw conversion.Hub) error {
 			Version: srcWl.Version,
 		})
 	}
-	dst.Spec.PreDeploymentTasks = src.Spec.PreDeploymentTasks
-	dst.Spec.PostDeploymentTasks = src.Spec.PostDeploymentTasks
-	dst.Spec.PreDeploymentEvaluations = src.Spec.PreDeploymentEvaluations
-	dst.Spec.PostDeploymentEvaluations = src.Spec.PostDeploymentEvaluations
 
 	dst.Status.CurrentVersion = src.Status.CurrentVersion
 
@@ -58,10 +54,6 @@ func (dst *KeptnApp) ConvertFrom(srcRaw conversion.Hub) error {
 			Version: srcWl.Version,
 		})
 	}
-	dst.Spec.PreDeploymentTasks = src.Spec.PreDeploymentTasks
-	dst.Spec.PostDeploymentTasks = src.Spec.PostDeploymentTasks
-	dst.Spec.PreDeploymentEvaluations = src.Spec.PreDeploymentEvaluations
-	dst.Spec.PostDeploymentEvaluations = src.Spec.PostDeploymentEvaluations
 
 	dst.Status.CurrentVersion = src.Status.CurrentVersion
 

lifecycle-operator/apis/lifecycle/v1alpha3/keptnapp_conversion_test.go

@@ -47,18 +47,6 @@ func TestKeptnApp_ConvertFrom(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: v1beta1.KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -89,18 +77,6 @@ func TestKeptnApp_ConvertFrom(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -163,18 +139,6 @@ func TestKeptnApp_ConvertTo(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: KeptnAppStatus{
 					CurrentVersion: "1.2.3",
@@ -205,18 +169,6 @@ func TestKeptnApp_ConvertTo(t *testing.T) {
 							Version: "4.5.6",
 						},
 					},
-					PreDeploymentTasks: []string{
-						"some-pre-deployment-task1",
-					},
-					PostDeploymentTasks: []string{
-						"some-post-deployment-task2",
-					},
-					PreDeploymentEvaluations: []string{
-						"some-pre-evaluation-task1",
-					},
-					PostDeploymentEvaluations: []string{
-						"some-pre-evaluation-task2",
-					},
 				},
 				Status: v1beta1.KeptnAppStatus{
 					CurrentVersion: "1.2.3",