test: improve metrics integration tests by adding kuttl log collectors

[rizul2108]

I have added collectors for the Metrics Integration Tests.

Fixes #2699

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71f20a6) 85.71% compared to head (29e4230) 85.62%.
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2765      +/-   ##
==========================================
- Coverage   85.71%   85.62%   -0.10%     
==========================================
  Files         160      160              
  Lines       10163    10140      -23     
==========================================
- Hits         8711     8682      -29     
- Misses       1171     1176       +5     
- Partials      281      282       +1     

see 13 files with indirect coverage changes

Flag	Coverage Δ
certificate-operator	67.42% <ø> (ø)
component-tests	56.18% <ø> (-1.50%)	⬇️
lifecycle-operator	84.62% <ø> (-0.11%)	⬇️
metrics-operator	87.65% <ø> (+<0.01%)	⬆️
scheduler	36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[odubajDT]

hello @rizul2108 !

Can you please fit the yamllint errors?

here are the logs:

./test/testmetrics/metrics-hpa/01-assert.yaml
23:5 error no new line character at the end of file (new-line-at-end-of-file)
23:1 error trailing spaces (trailing-spaces)

./test/testmetrics/metrics/02-teststep-assert.yaml
17:5 error no new line character at the end of file (new-line-at-end-of-file)
17:1 error trailing spaces (trailing-spaces)

Thank you!

[RealAnna]

Hi @rizul2108 thank you for your contribution! As by the issue, you need to modify your command to also log

1. metrics-operator pod
2. KeptnMetric and KeptnMetricsProvider

[rizul2108]

Hi @rizul2108 thank you for your contribution! As by the issue, you need to modify your command to also log

1. metrics-operator pod
   Can you please guide a little where I have to add collectors for this pod as I am unable to find the yaml file containing code for this pod?
2. KeptnMetric and KeptnMetricsProvider
   And I wanted to confirm for adding pod fo these 2 I have to make separate file named 00-assert.yaml in folder (https://github.com/keptn/lifecycle-toolkit/tree/main/test/testmetrics/metrics-provider ) or I can add collectors in already existing 00-install.yaml only ?

@RealAnna @odubajDT

[odubajDT]

Hi @rizul2108 thanks for reaching out

Hi @rizul2108 thank you for your contribution! As by the issue, you need to modify your command to also log

1. metrics-operator pod
   Can you please guide a little where I have to add collectors for this pod as I am unable to find the yaml file containing code for this pod?

metrics-operator is a standard pod in the Keptn default namespace (keptn-system). You should be able to access its logs in the same manner as you are already doing with the pods of the podtato-head application

2. KeptnMetric and KeptnMetricsProvider
   And I wanted to confirm for adding pod fo these 2 I have to make separate file named 00-assert.yaml in folder (https://github.com/keptn/lifecycle-toolkit/tree/main/test/testmetrics/metrics-provider ) or I can add collectors in already existing 00-install.yaml only ?

Please be aware, these are not pods, those are resources, you can execute kubectl describe on them

@RealAnna @odubajDT

[rizul2108]

Hi @rizul2108 thanks for reaching out

Hi @rizul2108 thank you for your contribution! As by the issue, you need to modify your command to also log

1. metrics-operator pod
   Can you please guide a little where I have to add collectors for this pod as I am unable to find the yaml file containing code for this pod?

metrics-operator is a standard pod in the Keptn default namespace (keptn-system). You should be able to access its logs in the same manner as you are already doing with the pods of the podtato-head application
So should I add command to get logs of metrics-operator pod to same 2 files where before I added?
@odubajDT

[odubajDT]

Hi @rizul2108 thanks for reaching out

Hi @rizul2108 thank you for your contribution! As by the issue, you need to modify your command to also log

1. metrics-operator pod
   Can you please guide a little where I have to add collectors for this pod as I am unable to find the yaml file containing code for this pod?

metrics-operator is a standard pod in the Keptn default namespace (keptn-system). You should be able to access its logs in the same manner as you are already doing with the pods of the podtato-head application
So should I add command to get logs of metrics-operator pod to same 2 files where before I added?
@odubajDT

You should get logs from the metrics-operator, for the rest should be enough to use kubectl describe

[rizul2108]

Ok sure, I will change it and push that in some time.

[rizul2108]

Can anyone of you please review it now? @RealAnna @odubajDT

[rizul2108]

The sonar cloud test is failing what I will have to change to pass this test?

[odubajDT]

The sonar cloud test is failing what I will have to change to pass this test?

That's not caused by your code changes, you can ignore the failure

[rizul2108]

The sonar cloud test is failing what I will have to change to pass this test?

That's not caused by your code changes, you can ignore the failure

Ok thanks @odubajDT

[sonarqubecloud]

Quality Gate failed

Failed conditions

3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[odubajDT]

Thank you for contribution!

[RealAnna]

LGTM thank you for the copntribution!