feat: add configurable caInjectionAnnotations for cert-manager support #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aryasoni98
changed the title
aryasoni98
changed the title
aryasoni98
changed the title
6 tasks
github-actions
bot
added
documentation
|
@odubajDT I just wanted to let you know that I've submitted PR. It would be great if you could take a look at it. Please let me know if there are any changes or improvements needed. Your feedback would be really valuable. |
RealAnna
reviewed
Dec 13, 2023
RealAnna
reviewed
Dec 13, 2023
RealAnna
reviewed
Dec 13, 2023
lifecycle-operator/chart/templates/keptnappcreationrequest-crd.yaml
Outdated
Show resolved
Hide resolved
RealAnna
reviewed
Dec 13, 2023
Signed-off-by: Arya Soni <[email protected]>
Signed-off-by: Arya Soni <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]> Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Arya Soni <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Arya Soni <[email protected]>
…#2651) Signed-off-by: Arya Soni <[email protected]>
Signed-off-by: Arya Soni <[email protected]>
|
@RealAnna I just fixed all the bugs. Please review it. |
mowies
requested changes
Dec 18, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a short summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes #2635
How to test
Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.
Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide
Summary
This PR introduces configurable annotations to support a variety of CA injection methods from cert-manager.io within the Keptn lifecycle toolkit. Previously, the annotation cert-manager.io/inject-ca-from: 'helmtests/keptn-certs' was hardcoded, limiting flexibility. The change allows users to specify any annotations for CA injection, enhancing the toolkit's integration capabilities with cert-manager.io.
Motivation: The motivation for this change is to provide users with the ability to tailor cert-manager.io integration to their specific needs, accommodating a broader range of certificate management scenarios.
Context: This change was prompted by user feedback and the need for more dynamic configuration options in cloud-native environments.
Dependencies: No additional dependencies are required for this change; however, users will need to have cert-manager.io configured in their Kubernetes cluster to utilize the new annotations.
Fixes #2635
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview