Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain quantity data type for analysis targets #2615

Merged
merged 12 commits into from
Dec 19, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Nov 30, 2023

Summary

Explains the use of Kubernetes quantity type rather than float for values specified for values in the target specification.

Fixes #2610

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • [ n/a] I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Nov 30, 2023
@StackScribe StackScribe added this to the 0.10 milestone Nov 30, 2023
@StackScribe StackScribe self-assigned this Nov 30, 2023
@StackScribe StackScribe requested review from a team as code owners November 30, 2023 06:35
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 61df2fd
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/657ac6bcd4b32100082d3895
😎 Deploy Preview https://deploy-preview-2615--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@StackScribe StackScribe marked this pull request as draft November 30, 2023 11:00
@StackScribe StackScribe marked this pull request as ready for review December 1, 2023 09:52
@odubajDT
Copy link
Contributor

odubajDT commented Dec 7, 2023

In general, didn't we agree on updating the docs-new folder from now on? @mowies @StackScribe

@mowies
Copy link
Member

mowies commented Dec 7, 2023

yes @odubajDT . new content should be added to the docs-new folder

StackScribe and others added 8 commits December 14, 2023 10:11
…n.md


Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
…n.md


Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
…n.md


Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: RealAnna <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please move the changes to the docs-new folder :)

Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@github-actions github-actions bot added the ops label Dec 18, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #2615 (ee95ab6) into main (601a053) will decrease coverage by 0.11%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
- Coverage   85.59%   85.48%   -0.11%     
==========================================
  Files         155      155              
  Lines       10175    10175              
==========================================
- Hits         8709     8698      -11     
- Misses       1190     1198       +8     
- Partials      276      279       +3     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.36% <ø> (-0.77%) ⬇️
lifecycle-operator 84.44% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@StackScribe StackScribe merged commit 1df7c66 into keptn:main Dec 19, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis: Non integer objective Quantity
5 participants