-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explain quantity data type for analysis targets #2615
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/content/en/docs/reference/crd-reference/analysisdefinition.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/reference/crd-reference/analysisdefinition.md
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
docs/content/en/docs/reference/crd-reference/analysisdefinition.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/reference/crd-reference/analysisdefinition.md
Outdated
Show resolved
Hide resolved
In general, didn't we agree on updating the |
yes @odubajDT . new content should be added to the |
docs/content/en/docs/reference/crd-reference/analysisdefinition.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Meg McRoberts <[email protected]>
…n.md Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
…n.md Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
…n.md Signed-off-by: Meg McRoberts [email protected] Co-authored-by: RealAnna <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
aca1152
to
61df2fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please move the changes to the docs-new
folder :)
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2615 +/- ##
==========================================
- Coverage 85.59% 85.48% -0.11%
==========================================
Files 155 155
Lines 10175 10175
==========================================
- Hits 8709 8698 -11
- Misses 1190 1198 +8
- Partials 276 279 +3 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Summary
Explains the use of Kubernetes
quantity
type rather thanfloat
for values specified for values in thetarget
specification.Fixes #2610
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview