Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
  • Loading branch information
odubajDT and StackScribe authored Feb 26, 2024
1 parent 0cddf6f commit f490048
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions docs/docs/components/lifecycle-operator/keptn-apps.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ Implementing Keptn applications provides the following benefits:
* You can define pre-deployment evaluations and tasks
that must all complete successfully
before the scheduler binds the pods to the nodes.
On information about how to disable the blocking
functionality please refer to
For information about how to disable the blocking
functionality, please refer to
[this section](./keptn-non-blocking.md#keptn-non-blocking-deployment-functionality).
* You can define post-deployment evaluations and tasks
that run only after all the workloads have completed successfully.
Expand Down
14 changes: 7 additions & 7 deletions docs/docs/components/lifecycle-operator/keptn-non-blocking.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ comments: true

Keptn provides an option to disable the default deployment blocking functionality
when pre-deployment tasks or evaluations (on KeptnApp or KeptnWorkload level) fail.
By creating a [KeptnConfig](../../reference/crd-reference/config.md) resources and
setting the `.spec.blockDeployment` parameter of to `false` the blocking
behavior for Keptn is disabled and therefore all applications will get deployed
to the cluster whether the pre-deployment tasks or evaluations fail.
By populating a [KeptnConfig](../../reference/crd-reference/config.md) resource and
setting the `.spec.blockDeployment` parameter to `false`, the blocking
behavior for Keptn is disabled and therefore all applications are deployed
to the cluster even if the pre-deployment tasks or evaluations fail.

This behavior is valuable if you want to execute a dry-run of the
tasks/evaluations for the application, but still have your application deployed
to the cluster not depending on the results of the pre-checks.
tasks/evaluations for the application but have your application deployed
to the cluster regardless of the results of the pre-checks.

If the checks of the application fail, the state of the deployment phase
are marked as `Warning` and you are able to inspect which
is marked as `Warning` and you are can inspect which
of the checks has failed.

```yaml
Expand Down

0 comments on commit f490048

Please sign in to comment.