Skip to content

Commit

Permalink
remove pre/post deployment tasks/evaluations from keptnapp in v1beta1
Browse files Browse the repository at this point in the history
Signed-off-by: geoffrey1330 <[email protected]>
  • Loading branch information
geoffrey1330 committed Jan 10, 2024
1 parent aba1543 commit 8a50ded
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
10 changes: 5 additions & 5 deletions lifecycle-operator/controllers/common/evaluation/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func TestEvaluationHandler(t *testing.T) {
name: "evaluation not started",
object: &v1beta1.KeptnAppVersion{
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentEvaluations: []string{"eval-def"},
},
},
Expand Down Expand Up @@ -102,7 +102,7 @@ func TestEvaluationHandler(t *testing.T) {
name: "already done evaluation",
object: &v1beta1.KeptnAppVersion{
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentEvaluations: []string{"eval-def"},
},
},
Expand Down Expand Up @@ -146,7 +146,7 @@ func TestEvaluationHandler(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentEvaluations: []string{"eval-def"},
},
},
Expand Down Expand Up @@ -208,7 +208,7 @@ func TestEvaluationHandler(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentEvaluations: []string{"eval-def"},
},
},
Expand Down Expand Up @@ -325,7 +325,7 @@ func TestEvaluationHandler_createEvaluation(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentEvaluations: []string{"eval-def"},
},
},
Expand Down
16 changes: 8 additions & 8 deletions lifecycle-operator/controllers/common/task/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func TestTaskHandler(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentTasks: []string{"task-def"},
},
},
Expand Down Expand Up @@ -99,7 +99,7 @@ func TestTaskHandler(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentTasks: []string{"task-def", "other-task-def"},
},
},
Expand Down Expand Up @@ -139,7 +139,7 @@ func TestTaskHandler(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentTasks: []string{"task-def"},
},
},
Expand Down Expand Up @@ -179,7 +179,7 @@ func TestTaskHandler(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentTasks: []string{"task-def"},
},
},
Expand Down Expand Up @@ -216,7 +216,7 @@ func TestTaskHandler(t *testing.T) {
name: "already done task",
object: &v1beta1.KeptnAppVersion{
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentTasks: []string{"task-def"},
},
},
Expand Down Expand Up @@ -260,7 +260,7 @@ func TestTaskHandler(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentTasks: []string{"task-def"},
},
},
Expand Down Expand Up @@ -312,7 +312,7 @@ func TestTaskHandler(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentTasks: []string{"task-def"},
},
},
Expand Down Expand Up @@ -424,7 +424,7 @@ func TestTaskHandler_createTask(t *testing.T) {
Namespace: "namespace",
},
Spec: v1beta1.KeptnAppVersionSpec{
KeptnAppSpec: v1beta1.KeptnAppSpec{
DeploymentTaskSpec: v1beta1.DeploymentTaskSpec{
PreDeploymentTasks: []string{"task-def"},
},
},
Expand Down

0 comments on commit 8a50ded

Please sign in to comment.