fix unknown states

Signed-off-by: odubajDT <[email protected]>
keptn · Feb 29, 2024 · 1f0ed52 · 1f0ed52
1 parent 88672ed
commit 1f0ed52
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lifecycle-operator/apis/lifecycle/v1beta1/common/common.go b/lifecycle-operator/apis/lifecycle/v1beta1/common/common.go
@@ -124,9 +124,12 @@ func GetOverallState(s StatusSummary) KeptnState {
 	if s.Pending > 0 {
 		return StatePending
 	}
-	if s.Unknown > 0 || s.GetTotalCount() != s.Total {
+	if s.Unknown > 0 {
 		return StateUnknown
 	}
+	if s.GetTotalCount() != s.Total {
+		return StatePending
+	}
 	return StateSucceeded
 }
 

diff --git a/lifecycle-operator/apis/lifecycle/v1beta1/common/common_test.go b/lifecycle-operator/apis/lifecycle/v1beta1/common/common_test.go
@@ -257,6 +257,11 @@ func Test_GeOverallState(t *testing.T) {
 			Summary: StatusSummary{1, 0, 0, 1, 0, 0, 0},
 			Want:    StateSucceeded,
 		},
+		{
+			Name:    "pending total count",
+			Summary: StatusSummary{2, 0, 0, 1, 0, 0, 0},
+			Want:    StatePending,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.Name, func(t *testing.T) {