adding tests in the common_test.go

keptn · Oct 16, 2024 · 06a7d81 · 06a7d81
1 parent 9f8605a
commit 06a7d81
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 3 deletions.
diff --git a/metrics-operator/controllers/common/providers/prometheus/common.go b/metrics-operator/controllers/common/providers/prometheus/common.go
@@ -4,12 +4,13 @@ import (
 	"context"
 	"crypto/tls"
 	"errors"
+	"net/http"
+
 	metricsapi "github.com/keptn/lifecycle-toolkit/metrics-operator/api/v1"
 	promapi "github.com/prometheus/client_golang/api"
 	"github.com/prometheus/common/config"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/types"
-	"net/http"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 

diff --git a/metrics-operator/controllers/common/providers/prometheus/common_test.go b/metrics-operator/controllers/common/providers/prometheus/common_test.go
@@ -128,21 +128,49 @@ func Test_GetRoundtripper(t *testing.T) {
 			provider: metricsapi.KeptnMetricsProvider{
 				ObjectMeta: metav1.ObjectMeta{Namespace: "default"},
 				Spec: metricsapi.KeptnMetricsProviderSpec{
-					TargetServer: "someTargetServer",
+					Type:         "",
+					TargetServer: "",
 					SecretKeyRef: v1.SecretKeySelector{
 						LocalObjectReference: v1.LocalObjectReference{
 							Name: "test",
 						},
 						Key:      "",
 						Optional: nil,
 					},
-					InsecureSkipTlsVerify: false,
 				},
 			},
 			k8sClient: fake.NewClient(goodsecret),
 			want:      config.NewBasicAuthRoundTripper("myuser", "mytoken", "", "", promapi.DefaultRoundTripper),
 			wantErr:   false,
 		},
+		{
+			name:      "TestSecretNotDefined",
+			provider:  metricsapi.KeptnMetricsProvider{},
+			k8sClient: fake.NewClient(),
+			want:      promapi.DefaultRoundTripper,
+			wantErr:   false,
+		},
+		{
+			name: "TestErrorFromGetPrometheusSecretNotExists",
+			provider: metricsapi.KeptnMetricsProvider{
+				ObjectMeta: metav1.ObjectMeta{Namespace: "default"},
+				Spec: metricsapi.KeptnMetricsProviderSpec{
+					Type:         "",
+					TargetServer: "",
+					SecretKeyRef: v1.SecretKeySelector{
+						LocalObjectReference: v1.LocalObjectReference{
+							Name: "test",
+						},
+						Key:      "",
+						Optional: nil,
+					},
+				},
+			},
+			k8sClient: fake.NewClient(),
+			want:      nil,
+			wantErr:   true,
+			errorStr:  "not found",
+		},
 		{
 			name: "TestInsecureSkipTlsVerifyEnabled",
 			provider: metricsapi.KeptnMetricsProvider{