refactor: separate monitoring configuration from project initialization #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Chila <[email protected]> BREAKING CHANGE: passing a monitoring type during init will make the pipeline fail! Please remove the argument and use keptnConfigureMonitoring
Signed-off-by: Paolo Chila <[email protected]>
pchila
force-pushed
the
refactor/separate-configure-monitoring-from-init
branch
from
3eb7d79 to
02ac640
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove monitoring configuration from
keptnInitand introduce a new functionkeptnConfigureMonitoringto be called after all the appropriate resources have been added to the keptn project.If
monitoringis still passed tokeptnInitthe pipeline will fail with an appropriate error message.Signed-off-by: Paolo Chila [email protected]
BREAKING CHANGE: passing a monitoring type during init will make the pipeline fail! Please remove the argument and use keptnConfigureMonitoring