Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor feature section with parallax effectFeature section refactor #4

Merged
merged 15 commits into from
Mar 27, 2024

Conversation

sahadat-sk
Copy link
Contributor

Fixes: #1674

Demo (Sorry for laggy video 😅):
keploy.webm

Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good initiative @sahadat-sk !

  • There's a lot of empty space over the first feature.
  • Once you scroll to the second feature the GIF transition should happen once the text of second feature has come to the middle of the first image.
  • In the small screen size this is completely breaking, please check the responsiveness.
Screenshot 2024-03-13 at 7 57 51 PM

@sahadat-sk sahadat-sk force-pushed the feature-section-refactor branch from deb7d38 to 372f779 Compare March 14, 2024 14:42
@sahadat-sk
Copy link
Contributor Author

Hey @nehagup can you review now?

@nehagup nehagup requested a review from Hermione2408 March 15, 2024 10:04
Copy link
Member

@Hermione2408 Hermione2408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahadat-sk Please revert back the linting changes

@Hermione2408
Copy link
Member

Hey @sahadat-sk Smooth transition kudos!

  • Please keep the Heading Intact and inside the view when the transition is happening.
  • Remove the empty space above first feature
  • Also I noticed you have removed the text "Give your teams the tool they need to move faster Accelerate development with streamlined testing, capturing network calls, automating scenarios, and seamless tool integration." try to accommodate it

@sahadat-sk
Copy link
Contributor Author

Hey @Hermione2408, I have made the requested changes, can you review them now?

</div>
</div>
</div>
</section>
<div className="max-w-6xl mx-auto mb-24 -mt-24 text-center">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sahadat-sk everything looks fine just remove this division it is not going well with the UI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@Hermione2408 Hermione2408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @nehagup

Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sahadat-sk ! A few changes.

  • The section is breaking on md and sm screen sizes, please stick to the same old format for md and sm screen size.
  • User needs to much scrolling from 1 feature to other, the second feature should start to appear as the first feature text comes to the top of container (attached screenshot)
Screenshot 2024-03-19 at 4 47 03 PM
  • can you please center align the 3rd GIF in center?
  • there's a lot of empty space after 3rd feature ends. Please reduce that to margins same as margins in other sections.
Screenshot 2024-03-19 at 4 54 57 PM

Rest looks good!

@sahadat-sk sahadat-sk force-pushed the feature-section-refactor branch from 333cacb to c6e5544 Compare March 19, 2024 14:10
@sahadat-sk
Copy link
Contributor Author

Thanks for the PR @sahadat-sk ! A few changes.

* The section is breaking on md and sm screen sizes, please stick to the same old format for md and sm screen size.

* User needs to much scrolling from 1 feature to other, the second feature should start to appear as the first feature text comes to the top of container (attached screenshot)
Screenshot 2024-03-19 at 4 47 03 PM
* can you please center align the 3rd GIF in center?

* there's a lot of empty space after 3rd feature ends. Please reduce that to margins same as margins in other sections.
Screenshot 2024-03-19 at 4 54 57 PM

Rest looks good!

I have made the changes, can you please review them!!

Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahadat-sk Everything else looks good! Just that First feature fades away before the first GIF comes even to the center. It's fine to remove the 3rd GIF and scroll the features-text with just 2 GIFs so that text gets more time and GIFs doesn't change too soon.

@sahadat-sk
Copy link
Contributor Author

@sahadat-sk Everything else looks good! Just that First feature fades away before the first GIF comes even to the center. It's fine to remove the 3rd GIF and scroll the features-text with just 2 GIFs so that text gets more time and GIFs doesn't change too soon.

Hey @nehagup, I have made the changes, do let me know if there is anything else I need to change!

@nehagup nehagup merged commit 7dc29e8 into keploy:main Mar 27, 2024
1 check passed
@sahadat-sk sahadat-sk deleted the feature-section-refactor branch March 27, 2024 12:57
@ethanwater ethanwater mentioned this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Refactor feature section with parallax effect
3 participants