best practices

Signed-off-by: Yash Khare <[email protected]>
keploy · Dec 16, 2024 · 983fceb · 983fceb
1 parent 9d071ff
commit 983fceb
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 45 deletions.
diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml
@@ -25,42 +25,6 @@ jobs:
         run: |
           npm install -g @lhci/[email protected]
           lhci autorun --config=lighthouserckeploy.json 
-      - name: List Application Reports
-        run: |
-          pwd
-          ls
-          echo "Listing Application Reports"
-          cd lhci-reports
-          ls
-          echo "Listing Application Reports1223"
-          cd app
-          ls
-          echo "Listing Application Report343"
-          cd ..
-          cd keploy.io
-          ls
-          echo "Listing Application Report78"
-          cd ..
-          cd ..
-          ls -la ./lhci-reports/app
-
-      - name: List Keploy.io Reports
-        run: ls -la ./lhci-reports/keploy.io/
       - name: Compare Lighthouse Reports
         run: |
-          pwd
-          ls
-          echo "Comparing Lighthouse Reports"
-          node compare-lhci-reports.js
-      # - name: Upload Lighthouse Reports
-      #   uses: actions/upload-artifact@v3
-      #   with:
-      #     name: lhci-reports
-      #     path: ./lhci-reports
-      # # After running LHCI for the Application
-      # - name: List Application Reports
-      #   run: ls -la ./lhci-reports/app/latest-run/
-
-      # # After running LHCI for Keploy.io
-      # - name: List Keploy.io Reports
-      #   run: ls -la ./lhci-reports/keploy.io/latest-run/
+          node compare-lhci-reports.js
diff --git a/compare-lhci-reports.js b/compare-lhci-reports.js
@@ -43,12 +43,14 @@ const categories = ['performance', 'accessibility', 'best-practices', 'seo'];
 let allPass = true;
 
 categories.forEach(category => {
-  const appScore = appReport.categories[category].score;
-  const keployScore = keployReport.categories[category].score;
-  console.log(`Comparing ${category}: App=${appScore} vs Keploy.io=${keployScore}`);
-  if (appScore < keployScore) {
-    console.error(`Score for ${category} is lower in the application (${appScore}) than Keploy.io (${keployScore})`);
-    allPass = false;
+  if (category != "best-practices"){
+    const appScore = appReport.categories[category].score;
+    const keployScore = keployReport.categories[category].score;
+    console.log(`Comparing ${category}: App=${appScore} vs Keploy.io=${keployScore}`);
+    if (appScore < keployScore) {
+      console.error(`Score for ${category} is lower in the application (${appScore}) than Keploy.io (${keployScore})`);
+      allPass = false;
+    }
   }
 });
 

diff --git a/lighthouserc.json b/lighthouserc.json
@@ -9,7 +9,7 @@
       "url": [
         "http://localhost:3000/"
       ],
-      "numberOfRuns": 1
+      "numberOfRuns": 5
     },
     "assert": {
       "assertions": {

diff --git a/lighthouserckeploy.json b/lighthouserckeploy.json
@@ -8,7 +8,7 @@
       "url": [
         "https://www.keploy.io"
       ],
-      "numberOfRuns": 1
+      "numberOfRuns": 5
     },
     "assert": {
       "assertions": {