Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMPSITE: To-Do Tests Teardown #33

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

CAMPSITE: To-Do Tests Teardown #33

wants to merge 3 commits into from

Conversation

kelseyroy
Copy link
Owner

Adds:

  • on_exit/1 statement to HTTPServerTest.ToDo
  • after_run hook in env.rb

Changes:

  • ToDo.DB.all/0 to return an empty map if file does not exist
  • Disables asynchronous test execution, which was causing failure in the pervious Teardown Campsite PR

@kelseyroy kelseyroy force-pushed the teardown-work branch 2 times, most recently from 99b55fb to 692dd96 Compare July 20, 2023 00:31
@Aoxian Aoxian added the Draft label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aoxian Aoxian Awaiting requested review from Aoxian

@t-keazirian t-keazirian Awaiting requested review from t-keazirian

@MarieRobinson MarieRobinson Awaiting requested review from MarieRobinson

Assignees
No one assigned
Labels
Draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelseyroy @Aoxian