Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENV variable ES_MULTILINGUAL_INDEX to default ENV variables #76

Closed
wants to merge 1 commit into from

Conversation

M-arcus
Copy link
Contributor

@M-arcus M-arcus commented Nov 15, 2023

1. Why is this change necessary?

This ENV variable is required to use Advanced Search 2.0, see installation requirements at https://developer.shopware.com/docs/products/extensions/advanced-search/installation.html

2. What does this change do, exactly?

It adds ENV variable ES_MULTILINGUAL_INDEX to default ENV variables

3. Describe each step to reproduce the issue or behaviour.

Run fully licensed Shopware 6.5.6.1 with Shopware Commercial installed but no ES_MULTILINGUAL_INDEX set.
The config settings for Advanced Search do not appear in the Administration settings.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written or adjusted the documentation according to my changes

@lx-wnk
Copy link
Contributor

lx-wnk commented Dec 4, 2023

Hey @M-arcus thank you for your contribution. Unfortunately, we have to reject it due to the existing feature flag. We try to offer only a standard setup with a minimum of predefined changes to ensure that it works with every project.

@lx-wnk lx-wnk closed this Dec 4, 2023
@M-arcus
Copy link
Contributor Author

M-arcus commented Dec 4, 2023

@jinnoflife I will add a feature flag and open a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants