Merge pull request #416 from keeps/alindo-dev2

Fixed NPE when metadata not selected
keeps · Mar 11, 2024 · 437a77c · 437a77c
2 parents ae6cbf5 + 885140b
commit 437a77c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/src/main/java/org/roda/rodain/core/creation/EarkSipCreator.java b/src/main/java/org/roda/rodain/core/creation/EarkSipCreator.java
@@ -146,6 +146,9 @@ private Pair createEarkSip(Sip descriptionObject) {
         if (metadataPath == null) {
           String content = descriptionObject.getMetadataWithReplaces(descObjMetadata);
           metadataPath = descObjMetadata.getPath();
+          if (metadataPath == null) {
+            metadataPath = tempDir.resolve(descObjMetadata.getId());
+          }
           FileUtils.writeStringToFile(metadataPath.toFile(), content, Constants.RODAIN_DEFAULT_ENCODING);
         }
 

diff --git a/src/main/java/org/roda/rodain/core/creation/HungarianSipCreator.java b/src/main/java/org/roda/rodain/core/creation/HungarianSipCreator.java
@@ -145,6 +145,9 @@ private Pair createHungarianSip(Sip descriptionObject) {
         if (metadataPath == null) {
           String content = descriptionObject.getMetadataWithReplaces(descObjMetadata);
           metadataPath = descObjMetadata.getPath();
+          if (metadataPath == null) {
+            metadataPath = tempDir.resolve(descObjMetadata.getId());
+          }
           FileUtils.writeStringToFile(metadataPath.toFile(), content, Constants.RODAIN_DEFAULT_ENCODING);
         }
 

diff --git a/src/main/java/org/roda/rodain/core/creation/SipCreator.java b/src/main/java/org/roda/rodain/core/creation/SipCreator.java
@@ -205,6 +205,9 @@ protected Pair createEarkSip(final Sip descriptionObject) {
         if (metadataPath == null) {
           final String content = descriptionObject.getMetadataWithReplaces(descObjMetadata);
           metadataPath = descObjMetadata.getPath();
+          if (metadataPath == null) {
+            metadataPath = tempDir.resolve(descObjMetadata.getId());
+          }
           FileUtils.writeStringToFile(metadataPath.toFile(), content, Constants.RODAIN_DEFAULT_ENCODING);
         }