Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve starknet-os/utils code #438

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve starknet-os/utils code #438

wants to merge 2 commits into from

Conversation

GMKrieger
Copy link
Collaborator

@GMKrieger GMKrieger commented Nov 25, 2024 •
edited
Loading

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Remove unused code from starknet-os/utils.rs file.

Add unit tests to starknet-os/utils.rs file.

Breaking changes?

  • yes
  • no

@GMKrieger GMKrieger self-assigned this Nov 25, 2024
@GMKrieger GMKrieger changed the title test: write tests for starknet-os utils Tests for starknet-os utils Nov 25, 2024
@GMKrieger GMKrieger changed the title Tests for starknet-os utils Improve starknet-os/utils code Nov 25, 2024
whichqua
whichqua previously requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@whichqua whichqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two PRs titles have the very similar titles, maybe change that?

@whichqua whichqua dismissed their stale review November 27, 2024 09:35

I think it should be ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftheirs ftheirs ftheirs approved these changes

@whichqua whichqua whichqua left review comments

@HermanObst HermanObst Awaiting requested review from HermanObst HermanObst is a code owner

@notlesh notlesh Awaiting requested review from notlesh notlesh is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@GMKrieger GMKrieger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GMKrieger @ftheirs @whichqua