Local devnet: fix block less than 10 #426
Conversation
| @@ -147,8 +147,11 @@ pub(crate) fn format_commitment_facts<H: HashFunctionType>( | |||
| impl PerContractStorage for ProverPerContractStorage { | |||
| async fn compute_commitment(&mut self) -> Result<CommitmentInfo, CommitmentInfoError> { | |||
| // TODO: error code | |||
There was a problem hiding this comment.
@ftheirs please add a comment that explain the motivation of this fix.
In general storage_proofs needs to have this field.
There was a problem hiding this comment.
Specifically which contracts are and why the start having contract_data in block 10
There was a problem hiding this comment.
In pathfinder, the structure from the requested type is defined with Opt:
https://github.com/Moonsong-Labs/pathfinder/blob/c45b23d2d6407079ad19f84ef0b23f913063d7cd/crates/rpc/src/pathfinder/methods/get_proof.rs#L182-L199
Besides, when we work with a devnet, we're returning in an early part of the function. We get a None when we retrieve the contract_state_hash from the DB, and this leads to the early return where most of the fields are empty/none
https://github.com/Moonsong-Labs/pathfinder/blob/c45b23d2d6407079ad19f84ef0b23f913063d7cd/crates/rpc/src/pathfinder/methods/get_proof.rs#L283-L294
When we bump into this condition, the fix just create a default ContractData structure with all fields in zero
ftheirs
force-pushed
the
ft/fix_blocks_less_than_10
branch
from
c586e5f
to
51c5693
Compare
ftheirs
force-pushed
the
ft/fix_blocks_less_than_10
branch
from
5a2a3f7
to
6611d38
Compare
Until block 10, contract_data field from storage_proof delivered by Pathfinder is None. Handle this situation with a default value.
Issue Number: N/A
Type
Description
Breaking changes?