Feat: Package compiled OS as gzip #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
suggested changes
Sep 12, 2024
Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Olivier Desenfans <[email protected]>
shamsasari
reviewed
Sep 13, 2024
shamsasari
reviewed
Sep 13, 2024
9 tasks
notlesh
changed the title
whichqua
approved these changes
Sep 18, 2024
9 tasks
|
This PR is now stagnating. Either update it or close if it's no longer going to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The compiled OS JSON is around 40M in size, and this gets absorbed as-is into the binary as a result of
include_bytes(...). In addition, we didn't include this in our source tree, requiring downstream users to figure out how to build it.Solution:
Gzip the OS JSON (this gets us from roughly 40M to 1M) and include this in the binary instead, then decompress it during runtime. Also, include this gzipped JSON so users will not have to worry about it.
The bad:
The downside of this is that we must decompress it at runtime, which looks to add about
0.07secat runtime on my machine.Additionally, including the compiled OS artifact in our source tree is less ideal than having a robust build system generate it as needed.
Issue Number: N/A
Type
Description
Breaking changes?