Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OP_LESSTHANOREQUAL impl #34

Merged
merged 3 commits into from
Jul 29, 2024
Merged

feat: OP_LESSTHANOREQUAL impl #34

merged 3 commits into from
Jul 29, 2024

Conversation

okhaimie-dev
Copy link
Contributor

@okhaimie-dev okhaimie-dev commented Jul 25, 2024 •
edited
Loading

@okhaimie-dev
Copy link
Contributor Author

okhaimie-dev commented Jul 25, 2024 •
edited
Loading

one of the tests still fails pending impl of at least OP_2 & OP_3

@okhaimie-dev okhaimie-dev marked this pull request as draft July 25, 2024 23:13
@b-j-roberts
Copy link
Contributor

I just merged this PR #32 adding OP_2 - OP_16.
If you can merge and resolve conflicts with main, I think this would be ready!

@okhaimie-dev okhaimie-dev marked this pull request as ready for review July 26, 2024 16:13
@b-j-roberts b-j-roberts merged commit 83dfed8 into keep-starknet-strange:main Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts Awaiting requested review from b-j-roberts b-j-roberts is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okhaimie-dev @b-j-roberts