Rename GroupID and change it to bytes #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs: #31 |
pdyraga
requested changes
Feb 19, 2019
|
@pdyraga ok addressed your comments, just to make sure this PR is about renaming/change type and to sync devs to use it asap, I expect the rest will be taken care of in forthcoming PRs (Phase 14, BLS and Requests) |
pdyraga
approved these changes
Feb 20, 2019
|
Testing... |
pdyraga
added
⛓️ solidity
🔀 relay
|
I've run 5 nodes and submitted relay entry to see if they enter the loop. Everything works fine, no problems found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #31
Rename GroupID since its technically a group public key and change it to bytes so we can store 64Bytes compressed BLS pub keys.