-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to threshold-network
and keep-network
projects
#212
base: main
Are you sure you want to change the base?
Changes from all commits
7bbb6f6
71f44ba
f2ad2a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -32,6 +32,15 @@ jobs: | |||||
node-version: "14.x" | ||||||
cache: "yarn" | ||||||
|
||||||
# We need this step because the `@keep-network/tbtc` which we install in | ||||||
# next step has a dependency to `@summa-tx/[email protected]` package, which | ||||||
# downloads one of its sub-dependencies via unathenticated `git://` | ||||||
# protocol. That protocol is no longer supported. Thanks to this step | ||||||
# `https://` is used instead of `git://`. | ||||||
- name: Configure git to don't use unauthenticated protocol | ||||||
shell: bash | ||||||
run: git config --global url."https://".insteadOf git:// | ||||||
|
||||||
- name: Install dependencies | ||||||
run: yarn install | ||||||
|
||||||
|
@@ -57,6 +66,15 @@ jobs: | |||||
node-version: "14.x" | ||||||
cache: "yarn" | ||||||
|
||||||
# We need this step because the `@keep-network/tbtc` which we install in | ||||||
# next step has a dependency to `@summa-tx/[email protected]` package, which | ||||||
# downloads one of its sub-dependencies via unathenticated `git://` | ||||||
# protocol. That protocol is no longer supported. Thanks to this step | ||||||
# `https://` is used instead of `git://`. | ||||||
- name: Configure git to don't use unauthenticated protocol | ||||||
shell: bash | ||||||
run: git config --global url."https://".insteadOf git:// | ||||||
|
||||||
- name: Install dependencies | ||||||
run: yarn install | ||||||
|
||||||
|
@@ -76,6 +94,15 @@ jobs: | |||||
cache: "yarn" | ||||||
registry-url: "https://registry.npmjs.org" | ||||||
|
||||||
# We need this step because the `@keep-network/tbtc` which we install in | ||||||
# next step has a dependency to `@summa-tx/[email protected]` package, which | ||||||
# downloads one of its sub-dependencies via unathenticated `git://` | ||||||
# protocol. That protocol is no longer supported. Thanks to this step | ||||||
# `https://` is used instead of `git://`. | ||||||
- name: Configure git to don't use unauthenticated protocol | ||||||
shell: bash | ||||||
run: git config --global url."https://".insteadOf git:// | ||||||
|
||||||
- name: Install dependencies | ||||||
run: yarn install --frozen-lockfile | ||||||
|
||||||
|
@@ -87,12 +114,14 @@ jobs: | |||||
query: | | ||||||
keep-core-contracts-version = github.com/keep-network/keep-core/solidity-v1#version | ||||||
tbtc-contracts-version = github.com/keep-network/tbtc/solidity#version | ||||||
solidity-contracts-version = github.com/threshold-network/solidity-contracts#version | ||||||
|
||||||
- name: Resolve latest contracts | ||||||
run: | | ||||||
yarn upgrade \ | ||||||
@keep-network/keep-core@${{ steps.upstream-builds-query.outputs.keep-core-contracts-version }} \ | ||||||
@keep-network/tbtc@${{ steps.upstream-builds-query.outputs.tbtc-contracts-version }} | ||||||
@keep-network/tbtc@${{ steps.upstream-builds-query.outputs.tbtc-contracts-version }} \ | ||||||
@threshold-network/solidity-contracts@${{ steps.upstream-builds-query.outputs.solidity-contracts-version }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
- name: Configure tenderly | ||||||
if: github.event.inputs.environment == 'ropsten' | ||||||
|
@@ -156,6 +185,15 @@ jobs: | |||||
node-version: "14.x" | ||||||
cache: "yarn" | ||||||
|
||||||
# We need this step because the `@keep-network/tbtc` which we install in | ||||||
# next step has a dependency to `@summa-tx/[email protected]` package, which | ||||||
# downloads one of its sub-dependencies via unathenticated `git://` | ||||||
# protocol. That protocol is no longer supported. Thanks to this step | ||||||
# `https://` is used instead of `git://`. | ||||||
- name: Configure git to don't use unauthenticated protocol | ||||||
shell: bash | ||||||
run: git config --global url."https://".insteadOf git:// | ||||||
|
||||||
- name: Install needed dependencies | ||||||
run: yarn install --frozen-lockfile | ||||||
|
||||||
|
@@ -186,6 +224,15 @@ jobs: | |||||
node-version: "14.x" | ||||||
cache: "yarn" | ||||||
|
||||||
# We need this step because the `@keep-network/tbtc` which we install in | ||||||
# next step has a dependency to `@summa-tx/[email protected]` package, which | ||||||
# downloads one of its sub-dependencies via unathenticated `git://` | ||||||
# protocol. That protocol is no longer supported. Thanks to this step | ||||||
# `https://` is used instead of `git://`. | ||||||
- name: Configure git to don't use unauthenticated protocol | ||||||
shell: bash | ||||||
run: git config --global url."https://".insteadOf git:// | ||||||
|
||||||
- name: Install dependencies | ||||||
run: yarn install | ||||||
|
||||||
|
@@ -222,6 +269,15 @@ jobs: | |||||
SLITHER_VERSION: 0.8.3 | ||||||
run: pip3 install slither-analyzer==$SLITHER_VERSION | ||||||
|
||||||
# We need this step because the `@keep-network/tbtc` which we install in | ||||||
# next step has a dependency to `@summa-tx/[email protected]` package, which | ||||||
# downloads one of its sub-dependencies via unathenticated `git://` | ||||||
# protocol. That protocol is no longer supported. Thanks to this step | ||||||
# `https://` is used instead of `git://`. | ||||||
- name: Configure git to don't use unauthenticated protocol | ||||||
shell: bash | ||||||
run: git config --global url."https://".insteadOf git:// | ||||||
|
||||||
- name: Install dependencies | ||||||
run: yarn install | ||||||
|
||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,15 @@ jobs: | |
node-version: "14" | ||
cache: "yarn" | ||
|
||
# We need this step because the `@keep-network/tbtc` which we install in | ||
# next step has a dependency to `@summa-tx/[email protected]` package, which | ||
# downloads one of its sub-dependencies via unathenticated `git://` | ||
# protocol. That protocol is no longer supported. Thanks to this step | ||
# `https://` is used instead of `git://`. | ||
- name: Configure git to don't use unauthenticated protocol | ||
shell: bash | ||
run: git config --global url."https://".insteadOf git:// | ||
|
||
- name: Install dependencies | ||
run: yarn install | ||
|
||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -24,11 +24,21 @@ jobs: | |||||
registry-url: "https://registry.npmjs.org" | ||||||
cache: "yarn" | ||||||
|
||||||
# We need this step because the `@keep-network/tbtc` which we update in | ||||||
# next step has a dependency to `@summa-tx/[email protected]` package, which | ||||||
# downloads one of its sub-dependencies via unathenticated `git://` | ||||||
# protocol. That protocol is no longer supported. Thanks to this step | ||||||
# `https://` is used instead of `git://`. | ||||||
- name: Configure git to don't use unauthenticated protocol | ||||||
shell: bash | ||||||
run: git config --global url."https://".insteadOf git:// | ||||||
|
||||||
- name: Resolve latest contracts | ||||||
run: | | ||||||
yarn upgrade \ | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's pin to exact dependencies versions. (see keep-network/keep-core#3083 for explaination)
Suggested change
|
||||||
@keep-network/keep-core \ | ||||||
@keep-network/tbtc | ||||||
@keep-network/tbtc \ | ||||||
@threshold-network/solidity-contracts | ||||||
|
||||||
# Deploy contracts to a local network to generate deployment artifacts that | ||||||
# are required by dashboard compilation. | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,6 +89,19 @@ yarn build | |
``` | ||
Compiled contracts will land in the `build/` directory. | ||
|
||
*NOTE:* The `coverage-pools` package contains an indirect dependency to | ||
`@summa-tx/[email protected]` package, which downloads one of its sub-dependencies | ||
via unathenticated `git://` protocol. That protocol is no longer supported by | ||
GitHub. This means that in certain situations installation of the package or | ||
update of its dependencies using Yarn may result in `The unauthenticated git | ||
protocol on port 9418 is no longer supported` or `fatal: unable to connect to | ||
github.com:` error. + | ||
As a workaround, we advise changing Git configuration to use `https://` protocol | ||
instead of `git://` by executing: | ||
``` | ||
git config --global url."https://".insteadOf git:// | ||
``` | ||
|
||
=== Test contracts | ||
|
||
There are multiple test scenarios living in the `test` directory. | ||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -35,10 +35,10 @@ | |||||||||
"prepublishOnly": "./scripts/prepare-artifacts.sh --network $npm_config_network" | ||||||||||
}, | ||||||||||
"dependencies": { | ||||||||||
"@keep-network/keep-core": ">1.8.0-dev <1.8.0-pre", | ||||||||||
"@keep-network/tbtc": ">1.1.2-dev <1.1.2-pre", | ||||||||||
"@keep-network/keep-core": ">1.8.0-dev <1.8.0-goerli", | ||||||||||
"@keep-network/tbtc": ">1.1.2-dev <1.1.2-goerli", | ||||||||||
Comment on lines
+38
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we use the
Suggested change
|
||||||||||
"@thesis/solidity-contracts": "github:thesis/solidity-contracts#4985bcf", | ||||||||||
"@threshold-network/solidity-contracts": ">1.1.0-dev <1.1.0-ropsten", | ||||||||||
"@threshold-network/solidity-contracts": "development", | ||||||||||
"@openzeppelin/contracts": "^4.3", | ||||||||||
"@tenderly/hardhat-tenderly": "^1.0.12" | ||||||||||
}, | ||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.