Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support github secret token and x-www-form-urlencoded #586

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support github secret token and x-www-form-urlencoded #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
363a359
mistypo
DingGGu Mar 3, 2021
6edb7b6
feat(github): Support x-www-form-urlencoded and github secret token
DingGGu Mar 3, 2021
a1a3636
test: Added test for handling github secret token
DingGGu Mar 4, 2021
2e55d6c
Update github_webhook_trigger.go
DingGGu Jul 29, 2021
7f7d656
Update github_webhook_trigger_test.go
DingGGu Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/keel/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func main() {
Store: sqlStore,
})

pendindApprovalsCounter := prometheus.NewGaugeFunc(prometheus.GaugeOpts{
pendingApprovalsCounter := prometheus.NewGaugeFunc(prometheus.GaugeOpts{
Name: "pending_approvals",
Help: "Number of the pending approvals",
}, func() float64 {
Expand All @@ -215,7 +215,7 @@ func main() {
}
return 0
})
prometheus.MustRegister(pendindApprovalsCounter)
prometheus.MustRegister(pendingApprovalsCounter)

go approvalsManager.StartExpiryService(ctx)

Expand Down
5 changes: 4 additions & 1 deletion constants/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const (
EnvMattermostName = "MATTERMOST_USERNAME"

// MS Teams webhook url, see https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/connectors-using#setting-up-a-custom-incoming-webhook
EnvTeamsWebhookUrl = "TEAMS_WEBHOOK_URL"
EnvTeamsWebhookUrl = "TEAMS_WEBHOOK_URL"

// Mail notification settings
EnvMailTo = "MAIL_TO"
Expand All @@ -52,5 +52,8 @@ const EnvBasicAuthPassword = "BASIC_AUTH_PASSWORD"
const EnvAuthenticatedWebhooks = "AUTHENTICATED_WEBHOOKS"
const EnvTokenSecret = "TOKEN_SECRET"

// Github Secret Token, see https://docs.github.com/en/developers/webhooks-and-events/securing-your-webhooks#validating-payloads-from-github
const EnvGithubSecretToken = "GITHUB_SECRET_TOKEN"

// KeelLogoURL - is a logo URL for bot icon
const KeelLogoURL = "https://keel.sh/images/logo.png"
6 changes: 4 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,21 @@ replace k8s.io/kubernetes => k8s.io/kubernetes v1.16.10

require (
cloud.google.com/go/pubsub v1.4.0
github.com/DATA-DOG/go-sqlmock v1.5.0 // indirect
github.com/Masterminds/semver v1.5.0
github.com/Masterminds/sprig v2.22.0+incompatible // indirect
github.com/aws/aws-sdk-go v1.31.10
github.com/daneharrigan/hipchat v0.0.0-20170512185232-835dc879394a
github.com/dgrijalva/jwt-go v3.2.0+incompatible
github.com/docker/distribution v2.7.1+incompatible
github.com/ghodss/yaml v1.0.0
github.com/golang/protobuf v1.4.2
github.com/google/go-github/v33 v33.0.1-0.20210226133809-b06cfbb1abc0
github.com/google/uuid v1.1.1
github.com/gorilla/mux v1.7.4
github.com/jinzhu/gorm v1.9.12
github.com/jmoiron/sqlx v1.2.0 // indirect
github.com/mattn/go-colorable v0.1.7 // indirect
github.com/mattn/go-runewidth v0.0.9 // indirect
github.com/mfridman/tparse v0.8.2 // indirect
github.com/nlopes/slack v0.6.0
github.com/opencontainers/go-digest v1.0.0
github.com/prometheus/client_golang v1.6.0
Expand All @@ -70,5 +71,6 @@ require (
k8s.io/cli-runtime v0.17.2
k8s.io/client-go v0.17.2
k8s.io/helm v0.0.0-00010101000000-000000000000
rsc.io/letsencrypt v0.0.3 // indirect
sigs.k8s.io/yaml v1.1.0
)
Loading