Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add json schema for values.yaml #30

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Add json schema for values.yaml #30

merged 5 commits into from
Nov 22, 2024

Conversation

jkremser
Copy link
Member

@jkremser jkremser commented Nov 21, 2024 •
edited
Loading

@jkremser
Add json schema for values.yaml + use alternateConfig instead of conf…
bdb95bb 
…ig for otel collector (easier to null the default values)

Signed-off-by: Jirka Kremser <[email protected]>
@jkremser jkremser requested a review from a team as a code owner November 21, 2024 15:52
@jkremser jkremser changed the title [wip] Add json schema for values.yaml Add json schema for values.yaml Nov 21, 2024
wozniakjan
wozniakjan approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

helmchart/otel-add-on/values.yaml Show resolved Hide resolved
@jkremser jkremser merged commit 8254447 into main Nov 22, 2024
3 checks passed
@jkremser jkremser deleted the alternateConfig+schema branch November 22, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkremser @wozniakjan