improve user experience with the full recovery mode #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
that referenced
this pull request
Oct 11, 2024
Predator keeps error recovery cheap in the default configuration. The special handling of `VO_DEREF_FAILED` on three places can now be disabled by setting `SE_ERROR_RECOVERY_MODE == 2`. Related: #102
kdudka
force-pushed
the
error-recovery
branch
from
eef195e to
248fd32
Compare
kdudka
added a commit
that referenced
this pull request
Oct 11, 2024
... so that it can call `objByOperand()`, which is protected. Related: #102
kdudka
added a commit
that referenced
this pull request
Oct 11, 2024
... to simulate that invalid operations may by chance write to the
target object within the allocated bounds. Nevertheless, the same
situation may happen with `executeMemset()`, `executeMemmove()`, etc.
With this change and `SE_ERROR_RECOVERY_MODE == 2`, Predator reports
one more error in the following example:
```
% nl -ba xxx.c
1 #include <verifier-builtins.h>
2
3 int main()
4 {
5 int a[10] = {0};
6 int i = __VERIFIER_nondet_int();
7 a[i] = 11;
8 a[a[1]] = 1;
9 }
% ./slgcc xxx.c
Trying to compile xxx.c ... OK
Running Predator ...
xxx.c:7:10: error: invalid dereference
xxx.c:8:13: error: invalid dereference
cl/cl_easy.cc:83: note: clEasyRun() took 0.000 s
FAILED
```
Related: #102
kdudka
added a commit
that referenced
this pull request
Oct 11, 2024
... so that one does not need to rebuild Predator from source code to enable full error recovery. Closes: #102
Predator keeps error recovery cheap in the default configuration. The special handling of `VO_DEREF_FAILED` on three places can now be disabled by setting `SE_ERROR_RECOVERY_MODE == 2`. Related: #102
... so that it can call `objByOperand()`, which is protected. Related: #102
... to simulate that invalid operations may by chance write to the
target object within the allocated bounds. Nevertheless, the same
situation may happen with `executeMemset()`, `executeMemmove()`, etc.
With this change and `SE_ERROR_RECOVERY_MODE == 2`, Predator reports
one more error in the following example:
```
% nl -ba xxx.c
1 #include <verifier-builtins.h>
2
3 int main()
4 {
5 int a[10] = {0};
6 int i = __VERIFIER_nondet_int();
7 a[i] = 11;
8 a[a[1]] = 1;
9 }
% ./slgcc xxx.c
Trying to compile xxx.c ... OK
Running Predator ...
xxx.c:7:10: error: invalid dereference
xxx.c:8:13: error: invalid dereference
cl/cl_easy.cc:83: note: clEasyRun() took 0.000 s
FAILED
```
Related: #102
... so that one does not need to rebuild Predator from source code to enable full error recovery. Closes: #102
kdudka
force-pushed
the
error-recovery
branch
from
248fd32 to
8b8964d
Compare
lzaoral
approved these changes
Oct 23, 2024
|
@lzaoral Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for details.