logs_reader: use get_log_events() #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered the hard way that the runtime of
FilterLogEventsis proportional to the number of streams (or perhaps total number of log messages), even when specifying an explicit stream in the filter. With a group that has thousands of streams, it can take "forever" (as-in, kill the process after 5 minutes of no output).GetLogEventssolves the performance issue. Unfortunately Boto doesn't provide a paginator for that API (see this for why), so it's not simply a matter of changing the function name (and thus, this PR to give more info).