Add APIBinding to make controller work

[vincent-pli]

Resolve issue #25

[openshift-ci]

Hi @vincent-pli. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevekuznetsov]

@vincent-pli could you remove this if we're adding this to the config itself? Does make test-e2e work for you locally with that removed?

[stevekuznetsov]

/ok-to-test

[stevekuznetsov]

Ignore that e2e :|

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vincent-pli
Once this PR has been reviewed and has the lgtm label, please ask for approval from stevekuznetsov by writing /assign @stevekuznetsov in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincent-pli]

@stevekuznetsov I have remove that code snippet and did some tiny update, the make test-e2e could work on my env.

[openshift-ci]

@vincent-pli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e	eac083b	link	true	/test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fgiloux]

In my opinion we should start tagging versions of the example with the release match.
go.mod is still with github.com/kcp-dev/kcp/pkg/apis v0.7.0, which has acceptedPermissionClaims
There is PR #30 that addresses the update of the versions. IMHO PR #30 could be merged first, which would accommodate the change here.

[nrb]

I'm +1 to making sure the releases match up to KCP's

[fgiloux]

For what it's worth kcp-dev/kcp#2135 has merged. As it is only in the main branch for now I still think that there is value in this PR.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ncdc]

/uncc