Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private OCI registry authentication #57

Merged

Conversation

bradkwadsworth-mw
Copy link

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

pkg/config

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Provider login credentials for private OCI registries.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
apiVersion: krm.kcl.dev/v1alpha1
kind: KCLRun
metadata:
  name: webapp
spec:
  params:
    metadata:
      name: "demo"
    containers:
      nginx:
        image: nginx
        ports:
          - containerPort: 8080
    service:
      ports:
        - port: 8080
  source: oci://<private module>
  credentials:
    url: https://<private registry login url>
   username: <username>
  password: <password>

Brad Wadsworth added 2 commits May 6, 2024 16:54
Signed-off-by: Brad Wadsworth <[email protected]>
@bradkwadsworth-mw bradkwadsworth-mw force-pushed the feature/private-oci-registries branch from 9f97beb to b19a2cf Compare May 6, 2024 21:54
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 9c320aa into kcl-lang:main May 7, 2024
4 checks passed
@Peefy
Copy link
Contributor

Peefy commented May 7, 2024

Thank you for the contribution. ❤

@bradkwadsworth-mw bradkwadsworth-mw deleted the feature/private-oci-registries branch May 7, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Private OCI Source Support for KRM KCL Spec
2 participants