Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor macOSUpgrade.sh #121

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Refactor macOSUpgrade.sh #121

merged 4 commits into from
Jul 1, 2019

Conversation

kenchan0130
Copy link
Collaborator

@kenchan0130 kenchan0130 commented Jun 28, 2019 •
edited
Loading

@kenchan0130
Refactor macOSUpgrade.sh
7dfbf94 
* Readable comment with space
* Using array variable with startosinstall options
@kenchan0130 kenchan0130 mentioned this pull request Jun 28, 2019
Open
@kenchan0130 kenchan0130 mentioned this pull request Jun 28, 2019
Open
taniguti
taniguti requested changes Jun 29, 2019
View reviewed changes
Copy link
Collaborator

@taniguti taniguti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional fix propose.

macOSUpgrade.sh Outdated Show resolved Hide resolved
taniguti
taniguti approved these changes Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@taniguti taniguti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenchan0130 kenchan0130 merged commit b4f08a5 into kc9wwh:master Jul 1, 2019
@kenchan0130 kenchan0130 deleted the refactor-macosupgrade branch July 1, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taniguti taniguti taniguti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenchan0130 @taniguti