Add cast modifier for boolean values #36
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Thank you for making
sweet_xml
, it works amazingly well. 😀While parsing an XML with some boolean values, I realised that boolean values are actually standardised in the XML Schema specification, with values
true
andfalse
(and non-canonically0
and1
).I think having a
b
modifier for the~x
sigil would be a nice addition! I have included a test case for casting withb
, and checking for the sigil withb
,bl
, andlb
Please let me know what you think, and if I need to make any additional changes!
Thanks again! 👋