Add Poll Tweets functionality #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See README changes for a description of the new functionality. The implementation is at the "get it working stage", not at the "get it right" stage. I'm also not a Typescript developer and have definitely committed some code violations. But it's powerful functionality and I'd like to get it out there early. Known issues: - Keys from https://ttm.kbravh.dev are not supported so you need a Twitter Developer bearer token. Which was actually a piece of cake when I tried it. - If settings like "noteLocation" or "pollFilename" are empty, strange things will happen. Defaults are not enforced. - An error like "images failed to download" sometimes appears. But images seem to be downloading. More investigation necessary. - There is very little feedback on progress to the user. This is challenging to do well. - The process cannot be interrupted (or monitored, easily), so mistakes can result in a lot of downloaded tweets! - Every Tweet duplicates a lot of front matter. On reflection, this is still better than any alternative I could think of. - Speaking of, the "fetch new tweets" functionality relies on frontmatter being present and will quietly download all tweets again if it is not there. - There is now a lot of code repetition. This is so my additions are well contained, rather than modifying too much existing code at this stage. - Testing, and tests, are basically non-existent at this stage.
|
@hraftery This is an awesome idea! 🤩 I'm a bit short for time right now, but I'll take a look at this later today or later this week for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a FYI at this stage and needs work before merge. I was looking for a way to sync my Twitter feed with my Obsidian vault and came across your impressive project. So I decided to build on top because there's a heck of lot of useful and hard-earned stuff here.
First pass implementation is now done, warts and all. It's very immature, but working a treat for me already, so I wanted to share it in case it can help others and get massaged into shape. See the README changes for a description of the new functionality, and the commit message for known issues.