Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.23.0 + Modify module logic changes #335

Merged
merged 2 commits into from
Dec 26, 2024
Merged

v0.23.0 + Modify module logic changes #335

merged 2 commits into from
Dec 26, 2024

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Dec 26, 2024

Description

Change modify module logic, tests are all backwards compatible except 1 which was corrected. This affects cases when merge_children and overriding are both set to True.

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 26, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 6f9bda2 Previous: cfc1f6f Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 15430.979543185145 iter/sec (stddev: 0.000014827463515953735) 14989.885574771877 iter/sec (stddev: 0.00001708589186409362) 0.97
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 675.716287137975 iter/sec (stddev: 0.000034770208197129974) 558.93442282316 iter/sec (stddev: 0.00032402227795837505) 0.83
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 12.05973711426476 iter/sec (stddev: 0.0024794791913281848) 11.73268022727456 iter/sec (stddev: 0.004286042547794756) 0.97
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 67.30305247408238 iter/sec (stddev: 0.0035930474259295146) 69.20622340700955 iter/sec (stddev: 0.0031646574598610533) 1.03
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 22638.365691913288 iter/sec (stddev: 0.000006681169132346653) 22712.922290046936 iter/sec (stddev: 0.000008758366013802232) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1716.6038160841308 iter/sec (stddev: 0.000010481868081677062) 1705.2762526226054 iter/sec (stddev: 0.000007878513045773557) 0.99
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 120.45850506247905 iter/sec (stddev: 0.0032322575045370372) 120.23956820143515 iter/sec (stddev: 0.003162600839788381) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 91.47279366317149 iter/sec (stddev: 0.0033639807498511546) 94.29235192847011 iter/sec (stddev: 0.003053433169424502) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan enabled auto-merge December 26, 2024 11:42
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2420 / 2420) 100% (1018 / 1018) 0

@kayjan kayjan merged commit 35cb5d6 into master Dec 26, 2024
6 checks passed
@kayjan kayjan deleted the v0.23.0 branch December 26, 2024 11:48
@kayjan kayjan added breaking New feature or request that is not backwards-compatible and removed enhancement New feature or request labels Dec 26, 2024
@kayjan kayjan changed the title v0.23.0 v0.23.0 + Modify module logic changes Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking New feature or request that is not backwards-compatible documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant