Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge attribute parameter to modify module #333

Merged
merged 8 commits into from
Dec 25, 2024

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Dec 25, 2024

Description

Testing

Add tests for shift, copy cases

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan
Copy link
Owner Author

kayjan commented Dec 25, 2024

#331

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: a2d79e7 Previous: 79058a5 Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 14940.748725558293 iter/sec (stddev: 0.00001588381033609688) 14671.296928046975 iter/sec (stddev: 0.000019023576576880055) 0.98
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 700.1572168021237 iter/sec (stddev: 0.000022108188489191414) 674.4976973495352 iter/sec (stddev: 0.00003922611229035991) 0.96
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 12.110466812276009 iter/sec (stddev: 0.0029189282367460974) 11.744098071336511 iter/sec (stddev: 0.002297668107882916) 0.97
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 70.03298928471904 iter/sec (stddev: 0.0030335238001821412) 63.7361460205048 iter/sec (stddev: 0.0044514488246296564) 0.91
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 22393.282014923687 iter/sec (stddev: 0.0000020481347916002817) 21317.211836330913 iter/sec (stddev: 8.860048023070963e-8) 0.95
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1708.7185140845693 iter/sec (stddev: 0.00005033355774161411) 1661.8550423666982 iter/sec (stddev: 0.00002495676815700336) 0.97
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 128.0313945270345 iter/sec (stddev: 0.002630990183516271) 109.68779737733274 iter/sec (stddev: 0.004182310195127124) 0.86
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 92.91377011666128 iter/sec (stddev: 0.0031731365186957856) 84.52060662045281 iter/sec (stddev: 0.004252870188790888) 0.91

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan added the enhancement New feature or request label Dec 25, 2024
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2430 / 2430) 100% (1019 / 1020) 0

@kayjan kayjan merged commit 4459ff4 into master Dec 25, 2024
6 checks passed
@kayjan kayjan deleted the feature/merge-attribute branch December 25, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant