Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull request template #302

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Update pull request template #302

merged 1 commit into from
Sep 10, 2024

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Sep 10, 2024

Description

Update pull request template phrasing

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases and ensured unit tests passed and code coverage is 100%.
  • I have ensured documentation and code docstrings are up-to-date.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added the documentation Improvements or additions to documentation label Sep 10, 2024
@kayjan kayjan enabled auto-merge September 10, 2024 14:02
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2347 / 2347) 100% (1167 / 1167) 0

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 74425a2 Previous: 6ab4073 Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 13454.65847351571 iter/sec (stddev: 0.000016100962828227874) 15511.8002143502 iter/sec (stddev: 0.00001479274457238575) 1.15
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 674.1907023239937 iter/sec (stddev: 0.00002128865172981558) 702.2115626504235 iter/sec (stddev: 8.452047364007655e-7) 1.04
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 11.632848489042987 iter/sec (stddev: 0.001248465894383845) 12.306337164136304 iter/sec (stddev: 0.0040740219534676735) 1.06
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 64.39443767029545 iter/sec (stddev: 0.004880508845083139) 69.1559464864285 iter/sec (stddev: 0.003215555359524447) 1.07
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 22227.72975968816 iter/sec (stddev: 0.0000022280227585549653) 22726.859511737417 iter/sec (stddev: 0.000002254963525379045) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1558.234090701888 iter/sec (stddev: 0.0000696971112598873) 1679.262535066176 iter/sec (stddev: 0.00004793816280741824) 1.08
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 104.76860541268582 iter/sec (stddev: 0.004646985487094277) 115.23310689567076 iter/sec (stddev: 0.0034080780500447675) 1.10
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 85.25866147857914 iter/sec (stddev: 0.004678513752122086) 87.1268023616765 iter/sec (stddev: 0.004361502367189029) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan merged commit e5f4baa into master Sep 10, 2024
6 checks passed
@kayjan kayjan deleted the add-mr-template branch September 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant