Add DISTINCT ON and LIMIT BY support to ClickHouse dialect #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of getting this reviewed and merged? I'm depending on this in an application I'm building and about to replace PyPika by something else as there seems almost zero movement in this project over the past few months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
DISTINCT ONandLIMIT BYsupport to the ClickHouse dialect.I'm not too happy that I had to add the
LIMIT BYto the_apply_paginationmethod and pass the**kwargsaround but I don't see any less intrusive way of doing this at the moment.