Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixes #791 #792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🐛 Fixes #791 #792

wants to merge 1 commit into from

Conversation

mvanderlee
Copy link
Contributor

@mvanderlee mvanderlee commented Feb 21, 2024 •
edited
Loading

Fixes #791

@mvanderlee mvanderlee requested a review from a team as a code owner February 21, 2024 22:42
@coveralls
Copy link

Coverage Status

coverage: 98.39%. remained the same
when pulling 8a81347 on mvanderlee:mvanderlee/791
into 8841520 on kayak:master.

@AzisK
Copy link

AzisK commented Feb 29, 2024

Looks good to me. @wd60622 could you take a look?

Could you also add tests?

@mvanderlee mvanderlee mentioned this pull request Apr 5, 2024
Merged
@AzisK
Copy link

AzisK commented Apr 26, 2024

What do you think @wd60622?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass kwargs through to get_function_sql
3 participants
@mvanderlee @coveralls @AzisK