fix: make pypika compatible with PEP 561 #757
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My local
mypy
setup had a few complaints about this package. In particular, as there are no stubs forpypika
available ontypeshed
, it lamented the missing typings. However, by looking at the source, it's clear that the type annotations are indeed available—they're just inlined.To fix that, I added a
py.typed
file inside my.venv/.../pypika
folder. It worked, so I'm replicating those changes upstream. My reference for the implementation was the mypy documentation. I've never published a package, so this is a stab in the dark for me. Hopefully, I hit the target 😜Cheers