Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make pypika compatible with PEP 561 #757

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fedetibaldo
Copy link

My local mypy setup had a few complaints about this package. In particular, as there are no stubs for pypika available on typeshed, it lamented the missing typings. However, by looking at the source, it's clear that the type annotations are indeed available—they're just inlined.

To fix that, I added a py.typed file inside my .venv/.../pypika folder. It worked, so I'm replicating those changes upstream. My reference for the implementation was the mypy documentation. I've never published a package, so this is a stab in the dark for me. Hopefully, I hit the target 😜

Cheers

@fedetibaldo fedetibaldo requested a review from a team as a code owner October 2, 2023 16:27
@fedetibaldo fedetibaldo changed the title Make pypika compatible with PEP 561 fix: make pypika compatible with PEP 561 Oct 3, 2023
@AzisK
Copy link

AzisK commented Oct 10, 2023

Hi @fedetibaldo, this is already being solved in #666. I see that you added it in the MANIFEST.in file. I am not sure if we need it here, let's read and ask around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants