feature: add deprecation warning for fetch_next

kayak · Jan 6, 2024 · 05e89eb · 05e89eb
1 parent a6c8b35
commit 05e89eb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/pypika/dialects.py b/pypika/dialects.py
@@ -1,4 +1,5 @@
 import itertools
+import warnings
 from copy import copy
 from typing import Any, Optional, Union, Tuple as TypedTuple
 
@@ -354,6 +355,11 @@ def _limit_sql(self) -> str:
     def _offset_sql(self) -> str:
         return " OFFSET {offset} ROWS".format(offset=self._offset or 0)
 
+    @builder
+    def fetch_next(self, limit: int):
+        warnings.warn("`fetch_next` is deprecated - please use the `limit` method", DeprecationWarning)
+        self._limit = limit
+
 
 class OracleQuery(Query):
     """

diff --git a/pypika/tests/dialects/test_oracle.py b/pypika/tests/dialects/test_oracle.py
@@ -41,3 +41,11 @@ def test_limit_offset_query(self):
         q = OracleQuery.from_(t).select(t.test).limit(limit).offset(offset)
 
         self.assertEqual(f'SELECT test FROM table1 OFFSET {offset} ROWS FETCH NEXT {limit} ROWS ONLY', str(q))
+
+    def test_fetch_next_method_deprecated(self):
+        with self.assertWarns(DeprecationWarning):
+            t = Table('table1')
+            limit = 5
+            q = OracleQuery.from_(t).select(t.test).fetch_next(limit)
+
+            self.assertEqual(f'SELECT test FROM table1 FETCH NEXT {limit} ROWS ONLY', str(q))