Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: add missing attach image #224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tinashechiraya
Copy link
Contributor

@tinashechiraya tinashechiraya commented Jan 13, 2025

still testing if the logo will appear in the email on dev

this is linked to issue:
#179

@tinashechiraya tinashechiraya added the bug Something isn't working label Jan 13, 2025
@tinashechiraya tinashechiraya self-assigned this Jan 13, 2025
@mvmaltitz mvmaltitz linked an issue Jan 14, 2025 that may be closed by this pull request
10 tasks
Copy link
Member

@dimasciput dimasciput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinashechiraya can you test this from your computer first? You can use the resend key from staging, and just send the email to you.

@tinashechiraya
Copy link
Contributor Author

Hi @LokoMoloko98 can i get the staging api key for resend

@LokoMoloko98
Copy link
Collaborator

LokoMoloko98 commented Jan 17, 2025

@tinashechiraya
Copy link
Contributor Author

@LokoMoloko98
the site cant be reached . i think i need a vpn

Screenshot from 2025-01-17 08-37-59

@LokoMoloko98
Copy link
Collaborator

@tinashechiraya yessir

@tinashechiraya
Copy link
Contributor Author

@LokoMoloko98 how do i do this

@tinashechiraya
Copy link
Contributor Author

Hi @dimasciput not sure if the resend key works on local or im doing something wrong . I get this error

{
"error": "Failed to send email: {"statusCode":403,"message":"The kartoza.com domain is not verified. Please, add and verify your domain on https://resend.com/domains\",\"name\":\"validation_error\"}"
}

@dimasciput
Copy link
Member

@tinashechiraya you need to use [email protected] for the sender.

@dimasciput
Copy link
Member

@tinashechiraya any update on this?

@tinashechiraya
Copy link
Contributor Author

Hi @dimasciput , yes I managed to send the emails locally but somehow the problem is still persisting . The logo is not appearing in the emails

I have tried
the CID way
econding the image to base64
switching to png
but still the image is not being rendered

can you have a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review current features and address technical debt on them.
3 participants