Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement session continuity #201

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Implement session continuity #201

wants to merge 30 commits into from

Conversation

tinashechiraya
Copy link
Contributor

@tinashechiraya tinashechiraya commented Dec 18, 2024 •
edited
Loading

this is linked to issue:
#66

Screencast.from.2024-12-18.01-54-26.webm

TODO

  • save analysis activity and allow user to resume
  • so so far it only remembers the last page you were on before the session expires or you were logged out ...now it needs to save the activities on that page
Screencast.from.2025-01-15.09-22-38.webm

@tinashechiraya tinashechiraya self-assigned this Dec 18, 2024
@tinashechiraya tinashechiraya marked this pull request as draft December 18, 2024 00:17
@tinashechiraya tinashechiraya added the Size 8 This is a full day job label Dec 18, 2024
@tinashechiraya
Copy link
Contributor Author

also resolved #227

@tinashechiraya tinashechiraya marked this pull request as ready for review January 15, 2025 07:49
dimasciput
dimasciput requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@dimasciput dimasciput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tinashechiraya Please update your PR, there are so many unrelated changes with the current ticket.

django_project/core/settings/prod.py Outdated
@@ -12,7 +12,8 @@
# ---------- EMAIL ------------ #
# -------------------------------------------------- #
# See fig.yml file for postfix container definition#
EMAIL_BACKEND = 'core.resend_email_backend.ResendBackend'
# EMAIL_BACKEND = 'core.resend_email_backend.ResendBackend'
EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use console?

django_project/base/templates/ARW_Admin has made you Organisation Manager.html
@@ -0,0 +1,71 @@
<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated with current PR

django_project/base/templates/approve_add_organization.html
@@ -0,0 +1,11 @@
{% extends "admin/base_site.html" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated

@dimasciput dimasciput marked this pull request as draft January 16, 2025 12:57
@tinashechiraya tinashechiraya mentioned this pull request Jan 16, 2025
Open
@tinashechiraya
Copy link
Contributor Author

I will dissolve this pr into multiple ones then close it @dimasciput

This was linked to issues Jan 22, 2025
Session Continuity Feature #66
Open
when session has expired should logout and redirect to login page #227
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimasciput dimasciput dimasciput requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@tinashechiraya tinashechiraya

Labels
Size 8 This is a full day job
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when session has expired should logout and redirect to login page Session Continuity Feature
2 participants
@tinashechiraya @dimasciput