Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readability #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion micrograd/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def __pow__(self, other):

def _backward():
self.grad += (other * self.data**(other-1)) * out.grad

out._backward = _backward

return out
Expand All @@ -52,16 +53,17 @@ def _backward():
return out

def backward(self):

# topological order all of the children in the graph
topo = []
visited = set()

def build_topo(v):
if v not in visited:
visited.add(v)
for child in v._prev:
build_topo(child)
topo.append(v)

build_topo(self)

# go one variable at a time and apply the chain rule to get its gradient
Expand Down