Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add missing husky package, sort out the eslint packages #316

Merged
merged 1 commit into from
Apr 19, 2022
Merged

build: add missing husky package, sort out the eslint packages #316

merged 1 commit into from
Apr 19, 2022

Conversation

XhmikosR
Copy link
Collaborator

@XhmikosR XhmikosR commented Apr 13, 2022 •
edited
Loading

Update update eslint-config-standard and downgrade eslint/eslint-plugin-promise because they are incompatible with eslint 8.x

Fixes #315

@XhmikosR XhmikosR added the dependencies Pull requests that update a dependency file label Apr 13, 2022
@XhmikosR XhmikosR marked this pull request as ready for review April 13, 2022 05:02
devoto13
devoto13 previously approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would only suggest to use build instead of the fix type in the commit message. fix type would trigger a new release, but this PR only changes development dependencies, so the release would be pretty much the same from the consumer perspective.

@XhmikosR XhmikosR changed the title fix(deps): add missing husky package, sort out the eslint packages build: add missing husky package, sort out the eslint packages Apr 13, 2022
@XhmikosR
build: add missing husky package, sort out the eslint packages
26d6a29 
Update update eslint-config-standard and downgrade eslint/eslint-plugin-promise because they are incompatible with eslint 8.x
@jginsburgn jginsburgn merged commit 963269d into master Apr 19, 2022
@jginsburgn jginsburgn deleted the xhm/deps branch April 19, 2022 05:02
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jginsburgn jginsburgn jginsburgn approved these changes

@devoto13 devoto13 devoto13 left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update eslint-config-standard
4 participants
@XhmikosR @karmarunnerbot @devoto13 @jginsburgn