Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint-config-standard #315

Closed
jginsburgn opened this issue Apr 12, 2022 · 4 comments · Fixed by #316
Closed

Update eslint-config-standard #315

jginsburgn opened this issue Apr 12, 2022 · 4 comments · Fixed by #316
Labels
released

Comments

@jginsburgn
Copy link
Member

The newer eslint-config-standard versions have no-var set to warn so we are flooded with warnings. I suggest someone else deals with this later if/when the supported browsers change.

Originally posted by @XhmikosR in #297 (comment)
@jginsburgn jginsburgn mentioned this issue Apr 12, 2022
Merged
5 tasks
@XhmikosR
Copy link
Collaborator

@jginsburgn
Copy link
Member Author

Can we not configure eslint's no-var rule to be supressed?

@XhmikosR
Copy link
Collaborator

Ah, true, my bad. I was under the impression we were using standard directly here, but I was obviously wrong. So, yeah, we can update to the latest version and adapt the rule.

@XhmikosR XhmikosR mentioned this issue Apr 13, 2022
Merged
@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: add missing husky package, sort out the eslint packages karma-runner/karma-jasmine
3 participants
@XhmikosR @karmarunnerbot @jginsburgn