Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking a look at assigned distance to PoT exogeneity #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

karimn
Copy link
Owner

@karimn karimn commented Jul 8, 2022

Also some small file and renv cleanup.

@karimn karimn requested a review from EdJeeOnGitHub July 8, 2022 18:29
@EdJeeOnGitHub
Copy link
Collaborator

I added some stuff at the bottom - I tried to do the BH thing which doesn't solve the external validity problem but is maybe a more convincing argument as to why we can use continuous distance even if we only randomise into close and far.

As I mentioned on slack I actually did this incorrectly but I think the principle would still aplly here

@karimn
Copy link
Owner Author

karimn commented Jul 11, 2022

Thanks for doing this. One small thing: I can run the code without a problem but when I try to render I get errors.

@EdJeeOnGitHub
Copy link
Collaborator

ah I had the same problem but only because I don't have quarto/pandoc installed so didn't notice if I added any markdown/latex errors.

Let me install and have a try at fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants