Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.5 compatibility #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Python 3.5 compatibility #29

wants to merge 1 commit into from

Conversation

yannforget
Copy link

Replaced dict.iteritems() with dict.items() in order to make the module compatible with Python 3.5.

Replaced `dict.iteritems()` with `dict.items()` in order to make the module compatible with Python 3.5.
@tmcw
Copy link
Contributor

tmcw commented Nov 7, 2016

It looks like, based on the upgrading notes, that the correct alternative would be iter(dict.items())?

@sgillies
Copy link
Contributor

sgillies commented Nov 7, 2016

@yannforget I'll merge this PR if you make the change suggested by @tmcw, but FYI the project is currently unmaintained and there are no future releases scheduled at this time.

@grinsted grinsted mentioned this pull request May 16, 2018
@AmitAronovitch
Copy link
Contributor

AmitAronovitch commented Jul 22, 2018

ping...
Made a new version of this fix #40
@sgillies : implemented there as @tmcw suggested, and also added test.
Can/should we revive this project? Or is there already some successor out there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants